Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in the residual layer #14

Open
mk-0 opened this issue Nov 22, 2021 · 1 comment
Open

A bug in the residual layer #14

mk-0 opened this issue Nov 22, 2021 · 1 comment

Comments

@mk-0
Copy link

mk-0 commented Nov 22, 2021

Thank you for this great project.
I've been playing with it for some time and noticed that FineADAINResBlock2d (and therefore also FineADAINResBlocks) is just a linear layer with no activation, because line 346 has self.conv2(x), instead of self.conv2(dx)

def forward(self, x, z):
dx = self.actvn(self.norm1(self.conv1(x), z))
dx = self.norm2(self.conv2(x), z)
out = dx + x
return out

@sdulyq
Copy link

sdulyq commented Oct 24, 2022

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants