Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaN and Inf pixels blowing up #210

Open
youreacoder opened this issue Apr 9, 2024 · 2 comments
Open

NaN and Inf pixels blowing up #210

youreacoder opened this issue Apr 9, 2024 · 2 comments

Comments

@youreacoder
Copy link

Hey !

We are using OIDN to directly denoise our renders (Houdini Karma), but whenever an inf pixel happens, the OIDN tries to create the gradient between its value and the rest of the image's pixels - creating huge glitch-like white areas like here :
Zrzut ekranu 2024-04-09 152250

Do you think there would be a way of making OIDN skip these kind of pixels, and potentially even fill them with surrounding pixels average data ?

Cheers!

@atafra
Copy link
Collaborator

atafra commented Apr 9, 2024

Hi. It's currently not possible to make OIDN ignore such extremely high values. This should be fixed on the rendering side. Enabling radiance clamping in the renderer should completely fix this issue.

@etheory
Copy link

etheory commented Dec 9, 2024

No decent renderer should output inf or NaN pixels. They should be filtered out by the renderer, I'm not sure it makes any sense to have OIDN handle them in some special way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants