Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation or examples for nested/multi-level instancing #547

Open
chegarty3 opened this issue Dec 15, 2022 · 2 comments
Open

Documentation or examples for nested/multi-level instancing #547

chegarty3 opened this issue Dec 15, 2022 · 2 comments

Comments

@chegarty3
Copy link

There are several issues regarding implementation of multi-level or nested instances.

#304
#256
#336
Those issues all generally are addressed with "will be implemented in V2.0".

In the V2.0 changelog, there is a commentary:
"The hierarchy of objects in a scene are now more granular to aid in scene construction flexibility and reduce potential object duplication"

But in combing through the examples, documentation, and code, I don't see anything to suggest multi-level instances (currently looking at V2.10). Is this not supported? Is it supported and not documented (hopefully)? I'm not looking for complex overrides; just a simple hierarchical scene graph. Something on the order of Instance -> Group -> Instance -> Group.

@johguenther
Copy link
Contributor

We removed the (only partly implemented) multi-level instancing in v2. The path to bring it back is like you sketched, adding an OSPInstance[] instance array to OSPGroup.

Would 2-level instancing be enough? Or indeed "unlimited" levels? We would still have a compile-time maximum number of nesting.

@chegarty3
Copy link
Author

chegarty3 commented Dec 22, 2022

For our purposes we would need "unlimited" levels (within a reasonable limit). It's pretty typical to have 3 or 4 levels of instancing where the top 1 or 2 levels are infrequent but the deeper 3 & 4 nested instances are very common throughout. It would be great to be able to leverage instances for those deeper, "common" instances.

Ultimately, a user could nest 100s of levels of instances but that is extremely unlikely and we would certainly work with a reasonable level constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants