Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeometryLight reduces effect of HDRILight #552

Open
mnaehrig opened this issue Jan 31, 2023 · 0 comments
Open

GeometryLight reduces effect of HDRILight #552

mnaehrig opened this issue Jan 31, 2023 · 0 comments
Labels

Comments

@mnaehrig
Copy link
Contributor

Following image was rendered via pathtracing. It contains just a single HDRI light and simple geometries with Principled materials:
hdri_only

If we add a geometry light (small sphere with Luminous material), the overall brightness is significantly reduced:
hdri_and_geometry_light

We found out that this issue was introduced with commit cbf9d26. So it can't be reproduced with OSPRay 2.7.1 and earlier. A possible fix is to change computation of selectionPDF in VirtualLight.ispc from:

const uniform float selectionPDF = rcp((uniform float)pathContext.numLights - w->pathtracerData.numGeoLights);

to:

const uniform float selectionPDF = rcp((uniform float)pathContext.numLights);

But currently I'm not sure if this change has unexpected side effects.

@johguenther johguenther added the bug label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants