-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToyCarSpecular.gltf is different from expected result #32
Comments
@cx20 do you have source of model, because I'm not sure about fabric material (The part of the cloth looks like a metallic luster). |
The glTF file is shown below, but you will have to ask the creator if there is an original source.
The areas that I see as metallic luster are as follows.
See below for the expected results of this model. Babylon.js seems to be the closest to the expected result so far. |
I confirmed this. Thank you for your support. |
@cx20 I’m trying to told you that Babylonjs is not source of true. To verify rendering we need some ground truth renderer, e.g. Blender etc. |
Below is the result of path-traced. Perhaps this is the expected result. |
@emackey Any advice on how to test |
We're still working to get a better test model for specular. The toy car is the only one available at this point, but for me at least, it's not intuitive why the car comes out that color. It would be better for us to have a model that's more explicit, but we don't have one yet. The closest thing to ground truth currently is a prototype path tracer from Dassault. But there was a change to the specular parameters just a couple weeks ago, and I don't know if this path tracer was updated to support that yet. This should all get straightened out before we send specular over for ratification. Live: https://dassaultsystemes-technology.github.io/dspbr-pt/ Source: https://github.com/dassaultsystemes-technology/dspbr-pt/ |
@emackey Thanks for the advice. I have tried Dassault's path tracer. Dassault's path tracer + ToyCarSpecular.gltf(using the Since this extension is not yet finished, we may have to work on another issue first. |
@cx20 fixed in 2.5.13 |
@Reon90 Thanks! It looks good.
|
@Reon90 The cloth seems dark when I view
|
fixed in 3.2.0 @cx20 |
@cx20 could you check? |
I have confirmed this model again with RedCube v3.3.0. I think the cloth is brighter than before. @emackey Is it possible to determine if the brightness of this cloth is correct? Personally, I don't feel so uncomfortable, so I feel that the test has passed. |
@cx20 Let's disregard the cloth on this particular version of the ToyCar model. Fabric and sheen effects have other tests that have already been merged into the official repo. This version of ToyCar is due to be replaced eventually. Thanks. |
I tried ToyCarSpecular.gltf, a draft model of Khronos. (The model has been renamed in the gltf-test repository to distinguish it from ToyCar.gltf.)
This model demonstrates the usage of
KHR_materials_specular
,KHR_materials_ior
,KHR_materials_transmission
andKHR_materials_clearcoat
.Please note that this model is different from this sample.
I noticed about two problems when compared with Babylon.js.
The text was updated successfully, but these errors were encountered: