Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walked through tutorial and didn't succeed #494

Open
dnkennedy opened this issue Jun 12, 2024 · 9 comments
Open

Walked through tutorial and didn't succeed #494

dnkennedy opened this issue Jun 12, 2024 · 9 comments

Comments

@dnkennedy
Copy link
Contributor

Hi. I tried to [sort of] follow the tutorial in the main documentation here.

I generated a protocol, and propagated it to my GitHub here.

My protocol pretty much followed the example tutorial protocol, using the phq9 example (tho in my real world case I will need to change that, but that's another discussion).

Thus, when I come to the "see how it looks" step, I believe that protocol url is:
https://raw.githubusercontent.com/dnkennedy/SimpleAssessment/main/protocols/simple.jsonld

and therefore I should be able to view this using:
https://www.repronim.org/reproschema-ui/#/?url=https://raw.githubusercontent.com/dnkennedy/SimpleAssessment/main/protocols/simple.jsonld

When I enter this in the (Chrome Version 125.0.6422.142 (Official Build) (x86_64)) browser I just get a spinning (binder-like?) wheel of death that never does anything.

I did use the jasonld validator, and that seemed OK.

I also know that there may be other example's I could have tried (cookie-cutter, etc.) but this was the first obvious tutorial I ran across.

Let me know what I missed!

@dnkennedy
Copy link
Contributor Author

Nevermind, user error on my part in the protocol file.

In the step where the assessment is added, there are changes both at the top in the 'context', and the added 'ui' content at the end of the file. Somehow the earlier instruction regarding "(and unless we explicitly say so) any new content we add to a file we have already worked on will be put at the end of this file" made me attend to only the 'ui' added content and I missed the update to the 'context'. Might be good to explicitly point out this 'context' update.

@Remi-Gau
Copy link
Collaborator

Thanks for the feedback!!!

We are planning to update the doc and refactor some redundancies. It is WIP (see for example: #487)

One thing I'd like to add is highlighting of the changed lines followed by an explanation why they were changed.

image

@Remi-Gau
Copy link
Collaborator

That being said I cannot tell you how many times I created some activity or protocol that was jsonld valid and reproschema valid only to end on the spinning wheel of death.

@dnkennedy
Copy link
Contributor Author

+1 (or even +100!) to the highlighting of the changes. So officially, my issue is resolved. I will close this?

@Remi-Gau
Copy link
Collaborator

Don't close it yet: just to make sure we have it as a reminder.

@yibeichan
Copy link
Contributor

thanks @dnkennedy and @Remi-Gau!! sorry, i can't get emails from github issues if I'm not tagged (I did check all my email settings)... yes, the highlight would be great! how do we do it ... @Remi-Gau you probably have magic tools...

@Remi-Gau
Copy link
Collaborator

Latest version of the doc includes code highlighting

https://www.repronim.org/reproschema/tutorials/finalizing-the-protocol/#adding-the-activity-to-the-protocol

image

Not sure why it's blue here and yellow when I try this locally.

@Remi-Gau
Copy link
Collaborator

@yibeichan

here is how to highlight specific lines:

```json linenums="1" hl_lines="25-29 33"

@yibeichan
Copy link
Contributor

cool! it's blue on my screen too! Blue aligns well with reproschema/repronim's theme color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants