Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maxLength back for string type responses #535

Open
satra opened this issue Aug 8, 2024 · 2 comments
Open

add maxLength back for string type responses #535

satra opened this issue Aug 8, 2024 · 2 comments

Comments

@satra
Copy link
Contributor

satra commented Aug 8, 2024

In some protocols, we have an maxLength property for text inputs. It would be good to add this one back to ResponseOption, unless we think we can use maxValue, but that doesn't seem semantically correct for a string type input.

just a note that this variable does not seem to be used in the UI at the moment.

@yibeichan
Copy link
Contributor

@djarecka i'm trying to understand how this works. so we should add maxLength to linkml-schema/reproschema.yaml and then everything will generate automatically, right?

@djarecka
Copy link
Member

The new version of the pydantic schema should be generated when running validate_and_release GA, and this is workflow has to be manually triggered. Look at the README and update if something is not clear.

fyi. with newer linkml you might have to update the command (removing --pydantic-version 2 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants