popup windows display the allow/deny bar in the wrong window

[msxfm]

Issue by alexlehm
Tuesday Mar 20, 2012 at 18:24 GMT
Originally opened as RequestPolicy/requestpolicy#297

---

when clicking on a link that opens a new empty window and then redirects this windows url to the target url, the yellow message bar with allow/deny is displayed in the opening window, not in the new window. this means that when you click allow, the wrong window displays the opened content.

[msxfm]

Comment by DavidJCobb
Saturday Oct 06, 2012 at 03:02 GMT

---

This also often happens when opening a link in a new tab, if that link redirects to a different URL. The opener tab (or sometimes both tabs) will show the Allow/Deny bar. If both tabs show that bar, then clicking Allow in one tab and switching to the other will re-show the bar in that other tab.

[nodiscc]

@alexlehm do you still have this problem? Is there a page where I can test this?

This also often happens when opening a link in a new tab, if that link redirects to a different URL. The opener tab (or sometimes both tabs) will show the Allow/Deny bar

I can't reproduce this either (for example, "open in new tab" on a google search result, the redirect warning appears in the proper tab). @DavidJCobb do you still have this problem or a link to a page where we can reproduce this?

Thanks

[alexlehm]

I am still seeing the issue, whether this happens depends on the way a redirect is implemented in a new window.
Please take a look at my example page at http://www.lehmann.cx/redirtest/ this has 4 kinds of redirects, the first two work, the last two don't.

Redirect with Refresh shows the warning bar in the original window and the new opened window (this is redir3 in my examples) and redirect by opening the window first and assigning a new url later shows the warning bar only in the original window (and redirects the wrong window afterwards) (this is redir4 in my examples)
The fourth example is not quite correctly implemented, I had to put in the alert to make the redirect work, however I have seen this kind of redirect and the issue with some pages which couldn't find again.

[myrdd]

@alexlehm I can confirm this bug for link redir3

[alexlehm]

I think I have found another instance where something similar happens. On twitter cards, a window is opened but the base page displays that a request to the target url was blocked.
E.g. if you take a look at this twitter post https://twitter.com/GeorgeTakei/status/532610034346106880 and click on view, it will show that a request to ohmyyy.gt was blocked and the opened page stays empty.
If the target domain is allowed before it works and the redirect to the domain is displayed in the correct window.

[nodiscc]

This is what I get on https://twitter.com/GeorgeTakei/status/532610034346106880 (default deny policy):

• left click on "View now" button: blank tab opens about:blank, no redirection warning. Going back to the twitter page now lists ohmyyy.gt as blocked target
• Ctrl+click: same result.
• Middle click: Firefox's popup warning, prevents from opening http://ohmyyy.gt/b3ZoD2, nothing gets added to RP̈́'s menu. No RP redirection warning either.

So this is another bug? I don't have redirection warnings (unless I whitelist ohmyyy.gt as you said, and then it's working as expected)

[alexlehm]

I think that is another variant of the same bug, the page that should receive the warning is the empty page, but the other page processes the redirect and blocks it. when the target domain is whitelisted it opens the windows and goes to the page, it also does so when requestpolicy is disabled.

[myrdd]

The bug @nodiscc describes (left-click and ctrl-click on https://twitter.com/GeorgeTakei/status/532610034346106880) is issue #36

Middle click: Firefox's popup warning, prevents from opening http://ohmyyy.gt/b3ZoD2, nothing gets added to RP̈́'s menu. No RP redirection warning either.

This has nothing to do with RP.

Btw @alexlehm I can also reproduce the bug for redir4.

[myrdd]

I will fix this bug after e10s compatibility is completed – see #489 (comment) for details

[myrdd]

I think this issue is solved. If not, please reopen.