Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter SiteEvaluations by timestamp #105

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Filter SiteEvaluations by timestamp #105

merged 2 commits into from
Oct 26, 2022

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh mvandenburgh commented Oct 25, 2022 •
edited
Loading

Closes #103

Uses django-filter to add filtering by timestamp range to the site evaluations endpoint.

The user can specify one or both of timestamp_before and timestamp_after as query params to the site evaluations endpoint to filter by date/time range. Uses the DateTimeFromToRangeFilter, docs are here https://django-filter.readthedocs.io/en/stable/ref/filters.html#datetimefromtorangefilter

@mvandenburgh mvandenburgh linked an issue Oct 25, 2022 that may be closed by this pull request
Allow filtering of the results using the timestamp #103
Open
mcovalt
mcovalt approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@mcovalt mcovalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@mvandenburgh mvandenburgh merged commit 6d3d47a into phase-ii Oct 26, 2022
@mvandenburgh mvandenburgh deleted the date-filter branch October 26, 2022 18:54
@mvandenburgh mvandenburgh mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcovalt mcovalt mcovalt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow filtering of the results using the timestamp
2 participants
@mvandenburgh @mcovalt