[wip] Fix satellite fetching race condition #514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you updated the task or the downloading of modelRun images but the same problem then exists, where the modelrun download requires that the celery task be up and running before it is initiated and generates the SatelliteFetching rows. This is going to require a change to: https://github.com/ResonantGeoData/RD-WATCH/blob/main/rdwatch/core/views/model_run.py#L511 |
|
This might still be an issue, but this PR is very outdated at this point and will likely need to be redone. I won't be working on this for the foreseeable future, so I'll close this and we can open a new one when/if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513.
This is only for the
coreapp; once we settle on the correct way to fix this, I'll apply it toscoringas well.