-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap to 2.3 #1406
Comments
If everything goes well, we'll release the RC tomorrow and close a lot of the issues marked as I moved some of the less non-implementation stuff to the final release date. Hopefully, we'll have only one |
Release candidate |
hello. any news on the final 2.3 version? |
Hi @andus4n, very few people tried the |
After seeing the above, I tested it out on |
@oschwald thanks for reporting this! I will look into it and get back to you soon. |
hi. any news? |
I'm sorry, @alganet! I completely overlooked this issue... 😅 The excellent news is that I released the 2.3 version! I've become less conservative about tidying up a version too much before releasing it. Maintaining an open-source project takes a lot of work. Over the years, there have been peaks of work from you and me, but keeping it consistent takes time and effort. That said, I'd rather enjoy those peaks and deliver value as soon as possible rather than make it perfect, which makes it harder for me and delays delivering value. What would you like to do with this issue? |
@henriquemoody, i noticed you renamed the "attribute" rule to "property"...this is a very bad move since i have literally thousands of entries for the old name. |
@andus4n, that is on In your case, wouldn't it be possible to replace those entries? If you're using it via rg '(v::|->)attribute\(' -l | xargs sed -Ei 's,(v::|->)attribute\(,\1property(,g' Then if you want to be safe which changes you would like to have or not you can always use |
@henriquemoody, i will use sed to replace the entries...but this is a major breaking change if you decide to release it (attribute is one of the most used rules). keep up the good work, this library's awesome. |
@andus4n, you will be pleased to know that I've created a way to keep the behaviour of the You can see the tests I've written here: https://github.com/Respect/Validation/blob/main/tests/integration/rules/deprecated/attribute.phpt It will trigger an |
I will close this one since version 2.3 was released. Once again, I'm sorry I didn't see that before releasing the version, @alganet 😞 |
To get a release candidate
2.3RC
:allmost issues and opened PRs, provide fix for all real bugs reported.To get a stable release
2.3.0
:oneOf
,allOf
andeach
validator messages.List of fixed issues for the this release
Tentative RC release date: 2023-03-01
Tentative stable release date: 2023-03-15
The text was updated successfully, but these errors were encountered: