Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1981: MultiProvider RC and Extensions API implementation: redundant code in SmsService and SmmpMessageHandler #2123

Closed
abdulazizali77 opened this issue May 4, 2017 · 1 comment
Closed

Issue #1981: MultiProvider RC and Extensions API implementation: redundant code in SmsService and SmmpMessageHandler #2123

abdulazizali77 opened this issue May 4, 2017 · 1 comment
Assignees
@gvagenas @abdulazizali77

Comments

@abdulazizali77
Copy link
Contributor

abdulazizali77 commented May 4, 2017 •
edited
Loading

Code to process and handle extension hooks, ExtensionRequests and ExtensionResponse in SmsService and SmppMessageHandler are identical (executePreOutboundAction executePostOutboundAction handleExtensionResponse ). This could be centralized in the Extensions Controller implementation or the RC Bootstrapper implementation.
This requires design discussion and iterative implementation of the Extensions API and implementation design.
This is blocked by #2125 and #2126
@abdulazizali77 abdulazizali77 changed the title Issue #1981: MultiProvider RC Extensions API: redundant code in SmsService and SmmpMessageHandler Issue #1981: MultiProvider RC and Extensions API implementation: redundant code in SmsService and SmmpMessageHandler May 4, 2017
@abdulazizali77
Copy link
Contributor Author

@gvagenas This is already fixed in the 09b166d
so closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvagenas gvagenas

@abdulazizali77 abdulazizali77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvagenas @abdulazizali77