Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to retire@1.1.5 to solve deprecated graceful-fs warnings #32

Closed
superclarkk opened this issue May 31, 2016 · 3 comments
Closed
Assignees

Comments

@superclarkk
Copy link

At installation, the latest grunt-retire (0.3.12) gives a warning that graceful-fs is deprecated, which has just been fixed in retire@1.1.5. See this issue for details.

@kozmic
Copy link
Member

kozmic commented May 31, 2016

Thanks for the report @superclarkk. I did some digging. In grunt-retire/package.json we use "retire": "~1.1.x" which resolves to retire@1.1.5 (so retire is not the cause of the warning). I think the root cause of the warning is grunt itself, see gruntjs/grunt-init#101. So the issue exist as long as you use Grunt 0.4.x. I've fixed this issue by requiring Grunt 1.0.x (or newer) and bumped versions of the corresponding contrib packages we use in grunt-retire. This makes this fix a breaking change since we require Grunt 1.0. Because of this I've decided I'll bump the version of grunt-retire to 1.0, which will include the fix for this issue.

Output of root cause analysis for the graceful-fs warning for grunt-retire@0.3.12 (latest):

$ grunt-retire staale$ npm ls graceful-fs
grunt-retire@0.3.12 grunt-retire
├─┬ grunt@0.4.5
│ └─┬ glob@3.1.21
│   └── graceful-fs@1.2.3
└─┬ retire@1.1.5
  └─┬ read-installed@4.0.3
    └── graceful-fs@4.1.4

@kozmic
Copy link
Member

kozmic commented May 31, 2016

As a reference, output of npm install of grunt-retire@1.0.0:

$ npm -v
2.14.4

$ npm install
async@1.5.2 node_modules/async

grunt-contrib-clean@1.0.0 node_modules/grunt-contrib-clean
└── rimraf@2.5.2 (glob@7.0.3)

grunt-contrib-nodeunit@1.0.0 node_modules/grunt-contrib-nodeunit
└── nodeunit@0.9.1 (tap@0.7.1)

grunt-contrib-jshint@1.0.0 node_modules/grunt-contrib-jshint
├── hooker@0.2.3
├── chalk@1.1.3 (escape-string-regexp@1.0.5, ansi-styles@2.2.1, supports-color@2.0.0, strip-ansi@3.0.1, has-ansi@2.0.0)
└── jshint@2.9.2 (strip-json-comments@1.0.4, exit@0.1.2, shelljs@0.3.0, console-browserify@1.1.0, minimatch@2.0.10, cli@0.6.6, htmlparser2@3.8.3, lodash@3.7.0)

request@2.67.0 node_modules/request
├── aws-sign2@0.6.0
├── tunnel-agent@0.4.3
├── oauth-sign@0.8.2
├── forever-agent@0.6.1
├── caseless@0.11.0
├── is-typedarray@1.0.0
├── stringstream@0.0.5
├── isstream@0.1.2
├── json-stringify-safe@5.0.1
├── extend@3.0.0
├── form-data@1.0.0-rc4
├── tough-cookie@2.2.2
├── node-uuid@1.4.7
├── qs@5.2.0
├── combined-stream@1.0.5 (delayed-stream@1.0.0)
├── mime-types@2.1.11 (mime-db@1.23.0)
├── hawk@3.1.3 (cryptiles@2.0.5, boom@2.10.1, sntp@1.0.9, hoek@2.16.3)
├── bl@1.0.3 (readable-stream@2.0.6)
├── http-signature@1.1.1 (assert-plus@0.2.0, jsprim@1.2.2, sshpk@1.8.3)
└── har-validator@2.0.6 (chalk@1.1.3, commander@2.9.0, pinkie-promise@2.0.1, is-my-json-valid@2.13.1)

retire@1.1.5 node_modules/retire
├── commander@2.5.1
├── underscore@1.8.3
├── walkdir@0.0.7
└── read-installed@4.0.3 (debuglog@1.0.1, util-extend@1.0.3, graceful-fs@4.1.4, slide@1.1.6, semver@5.1.0, readdir-scoped-modules@1.0.2, read-package-json@2.0.4)

grunt@1.0.1 node_modules/grunt
├── grunt-known-options@1.1.0
├── path-is-absolute@1.0.0
├── eventemitter2@0.4.14
├── rimraf@2.2.8
├── exit@0.1.2
├── iconv-lite@0.4.13
├── coffee-script@1.10.0
├── glob@7.0.3 (inherits@2.0.1, inflight@1.0.5, once@1.3.3)
├── findup-sync@0.3.0 (glob@5.0.15)
├── nopt@3.0.6 (abbrev@1.0.7)
├── grunt-cli@1.2.0 (resolve@1.1.7)
├── minimatch@3.0.0 (brace-expansion@1.1.4)
├── js-yaml@3.5.5 (esprima@2.7.2, argparse@1.0.7)
├── grunt-legacy-util@1.0.0 (getobject@0.1.0, hooker@0.2.3, which@1.2.9, underscore.string@3.2.3, lodash@4.3.0)
├── grunt-legacy-log@1.0.0 (hooker@0.2.3, colors@1.1.2, underscore.string@3.2.3, lodash@3.10.1, grunt-legacy-log-utils@1.0.0)
└── dateformat@1.0.12 (get-stdin@4.0.1, meow@3.7.0)

@kozmic kozmic closed this as completed in e980e0a May 31, 2016
@superclarkk
Copy link
Author

we use "retire": "~1.1.x" which resolves to retire@1.1.5

Thanks for looking at this so quickly.

I have to admit that I didn't install grunt-retire since the latest version of retire was released. Thus, I think the semver you were using would probably have automatically resolved the message without any other changes.

@kozmic kozmic self-assigned this Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants