Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings not saved when closing windows by ESC #1455

Closed
Spikeone opened this issue Nov 2, 2021 · 3 comments · Fixed by #1458
Closed

Settings not saved when closing windows by ESC #1455

Spikeone opened this issue Nov 2, 2021 · 3 comments · Fixed by #1458

Comments

@Spikeone
Copy link
Member

Spikeone commented Nov 2, 2021

When closing windows by using ESC rather than right click, the settings are not saved but reset to their previous state.

Simply open the Tool Settings, set one to 100% that was not 100%, hit escape (closing the window), open it again and you see the previous value. When using right click everything is working as expected.

@Flow86
Copy link
Member

Flow86 commented Nov 3, 2021

I think this is expected. I'm not sure if this was the same in the original? (Like "OK"=Right click, "Cancel"=Escape)

@Spikeone
Copy link
Member Author

Spikeone commented Nov 3, 2021

It's still strange as: keep the window open for 30 minutes, hit escape, settings reset.

Doesn't feel intuitive, but not sure if its correct (as in the original) or not

@Flamefire
Copy link
Member

Tested in DosBox: Seems to be Right-Click and ESC are the same, so settings saved for both.
Still strange: Settings should in any case be applied directly, i.e. no matter if the window is closed at all the settings should be changed.

So yes, this is a valid bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants