Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] experiment: add @_spi attribute as an experiment #4700

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajpallares
Copy link
Member

Experiment of @_spi attribute for future internal APIs (see https://swiftpackageindex.com/swiftlang/swift-syntax/600.0.1/documentation/swiftsyntax/spi)

@ajpallares
Copy link
Member Author

@RCGitBot please test

@aboedo
Copy link
Member

aboedo commented Jan 23, 2025

@ajpallares I'll add the pr:other label so Danger doesn't complain.

But... installation tests passed! 🎉

Although... should they have? LOL like, isn't it expected that things that use the Purchases.shared.appUserID property would have failed to compile? Am I missing something?

@ajpallares
Copy link
Member Author

@aboedo well, it turns out I was too conservative when adding the @_spi attribute and added to a property that is also exposed via the PurchasesType protocol 🤦‍♂️
I'll be more aggressive now and test it in the configure method 😄
At least we now know that adding some @_spis does not break anything 😅

@ajpallares
Copy link
Member Author

@RCGitBot please test

@aboedo
Copy link
Member

aboedo commented Jan 27, 2025

tests fail now, uhh yay I guess lol 🎉
image

@ajpallares
Copy link
Member Author

I think we can close this PR as it already served its purpose. @RevenueCat/coresdk is there anything else that is worth testing for this @_spi attribute?

@tonidero
Copy link
Contributor

Hmm I think that covers everything 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants