-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValueError: Invalid file descriptor: -1
in asyncio
#23
Comments
@garrison thanks for reporting. So treon doesn't use asyncio (at least not directly), we use ThreadPool for parallelisation. Can we see a longer stack trace? I'm thinking the error might be coming from actual notebook code cell execution that happens as part of running the notebook for testing. |
@amit1rrr That's very interesting. There is nothing more to the stacktrace beyond what I posted. None of my notebooks call asyncio directly, either, and to the best of my knowledge they are not calling any code that would rely on asyncio. I'm going to pay careful attention to the circumstances in which I can reproduce this. Maybe there's something special about one of the notebooks I am testing against. Or maybe I will find that I can reproduce it even with a single, very simple notebook. I'll keep you posted. |
Yes, if it's possible to reproduce it consistently on some notebooks then it would be easier to dig deeper.
This might also be a good elimination strategy. If we're suspecting this happens as part of notebook code cell execution then it should happen even when treon is running single threaded. If it does not happen then there's something within treon (or it's dependencies) that needs fixing. |
I often (but not always) witness treon output the following error just before exiting:
Treon then goes on to exit with a successful error code, so it's effectively just a warning, even though it is caused by a
ValueError
. I've witnessed this on multiple versions of python..I typically invoke treon as
treon . --threads 2
. I suspect this warning might go away if I don't use threads, but I haven't investigated it yet.The text was updated successfully, but these errors were encountered: