Merge pull request modelcontextprotocol#504 from modelcontextprotocol/jerome/fix/linting

Fixing linting issues from previous bug fix

Author: jerome3o-anthropic

.git-blame-ignore-revs

@@ -349,9 +349,9 @@ const App = () => {
     const headers: HeadersInit = {};
     const proxyAuthToken = getMCPProxyAuthToken(config);
     if (proxyAuthToken) {
-      headers['Authorization'] = `Bearer ${proxyAuthToken}`;
+      headers["Authorization"] = `Bearer ${proxyAuthToken}`;
     }
-    
+
     fetch(`${getMCPProxyAddress(config)}/config`, { headers })
       .then((response) => response.json())
       .then((data) => {

client/src/App.tsx

@@ -84,12 +84,6 @@ Object.defineProperty(window, "sessionStorage", {
   value: sessionStorageMock,
 });
 
-Object.defineProperty(window, "location", {
-  value: {
-    origin: "http://localhost:3000",
-  },
-});
-
 describe("AuthDebugger", () => {
   const defaultAuthState = EMPTY_DEBUGGER_STATE;
 
@@ -104,7 +98,7 @@ describe("AuthDebugger", () => {
     jest.clearAllMocks();
     sessionStorageMock.getItem.mockReturnValue(null);
 
-    // Supress
+    // Suppress console errors in tests to avoid JSDOM navigation noise
     jest.spyOn(console, "error").mockImplementation(() => {});
 
     mockDiscoverOAuthMetadata.mockResolvedValue(mockOAuthMetadata);
@@ -447,18 +441,6 @@ describe("AuthDebugger", () => {
     it("should store auth state to sessionStorage before redirect in Quick OAuth Flow", async () => {
       const updateAuthState = jest.fn();
 
-      // Mock window.location.href setter
-      const originalLocation = window.location;
-      const locationMock = {
-        ...originalLocation,
-        href: "",
-        origin: "http://localhost:3000",
-      };
-      Object.defineProperty(window, "location", {
-        writable: true,
-        value: locationMock,
-      });
-
       // Setup mocks for OAuth flow
       mockStartAuthorization.mockResolvedValue({
         authorizationUrl: new URL(

client/src/components/__tests__/AuthDebugger.test.tsx

@@ -519,6 +519,7 @@ describe("Sidebar Environment Variables", () => {
             label: "Request Timeout",
             description: "Timeout for requests to the MCP server (ms)",
             value: 5000,
+            is_session_item: false,
           },
         }),
       );
@@ -544,6 +545,7 @@ describe("Sidebar Environment Variables", () => {
             description:
               "Set this if you are running the MCP Inspector Proxy on a non-default address. Example: http://10.1.1.22:5577",
             value: "http://localhost:8080",
+            is_session_item: false,
           },
         }),
       );
@@ -569,6 +571,7 @@ describe("Sidebar Environment Variables", () => {
             description:
               "Maximum total timeout for requests sent to the MCP server (ms) (Use with progress notifications)",
             value: 10000,
+            is_session_item: false,
           },
         }),
       );
@@ -591,6 +594,7 @@ describe("Sidebar Environment Variables", () => {
             label: "Request Timeout",
             description: "Timeout for requests to the MCP server (ms)",
             value: 0,
+            is_session_item: false,
           },
         }),
       );
@@ -637,6 +641,7 @@ describe("Sidebar Environment Variables", () => {
             label: "Request Timeout",
             description: "Timeout for requests to the MCP server (ms)",
             value: 3000,
+            is_session_item: false,
           },
         }),
       );

client/src/components/__tests__/Sidebar.test.tsx

@@ -246,7 +246,7 @@ export function useConnection({
       const proxyAuthToken = getMCPProxyAuthToken(config);
       const headers: HeadersInit = {};
       if (proxyAuthToken) {
-        headers['Authorization'] = `Bearer ${proxyAuthToken}`;
+        headers["Authorization"] = `Bearer ${proxyAuthToken}`;
       }
       const proxyHealthResponse = await fetch(proxyHealthUrl, { headers });
       const proxyHealth = await proxyHealthResponse.json();
@@ -269,7 +269,7 @@ export function useConnection({
 
   const isProxyAuthError = (error: unknown): boolean => {
     return (
-      error instanceof Error && 
+      error instanceof Error &&
       error.message.includes("Authentication required. Use the session token")
     );
   };
@@ -335,7 +335,7 @@ export function useConnection({
       const proxyAuthToken = getMCPProxyAuthToken(config);
       const proxyHeaders: HeadersInit = {};
       if (proxyAuthToken) {
-        proxyHeaders['Authorization'] = `Bearer ${proxyAuthToken}`;
+        proxyHeaders["Authorization"] = `Bearer ${proxyAuthToken}`;
       }
 
       // Create appropriate transport
@@ -356,7 +356,11 @@ export function useConnection({
               fetch: (
                 url: string | URL | globalThis.Request,
                 init: RequestInit | undefined,
-              ) => fetch(url, { ...init, headers: { ...headers, ...proxyHeaders } }),
+              ) =>
+                fetch(url, {
+                  ...init,
+                  headers: { ...headers, ...proxyHeaders },
+                }),
             },
             requestInit: {
               headers: { ...headers, ...proxyHeaders },
@@ -372,7 +376,11 @@ export function useConnection({
               fetch: (
                 url: string | URL | globalThis.Request,
                 init: RequestInit | undefined,
-              ) => fetch(url, { ...init, headers: { ...headers, ...proxyHeaders } }),
+              ) =>
+                fetch(url, {
+                  ...init,
+                  headers: { ...headers, ...proxyHeaders },
+                }),
             },
             requestInit: {
               headers: { ...headers, ...proxyHeaders },
@@ -388,7 +396,11 @@ export function useConnection({
               fetch: (
                 url: string | URL | globalThis.Request,
                 init: RequestInit | undefined,
-              ) => fetch(url, { ...init, headers: { ...headers, ...proxyHeaders } }),
+              ) =>
+                fetch(url, {
+                  ...init,
+                  headers: { ...headers, ...proxyHeaders },
+                }),
             },
             requestInit: {
               headers: { ...headers, ...proxyHeaders },
@@ -471,7 +483,8 @@ export function useConnection({
         if (isProxyAuthError(error)) {
           toast({
             title: "Proxy Authentication Required",
-            description: "Please enter the session token from the proxy server console in the Configuration settings.",
+            description:
+              "Please enter the session token from the proxy server console in the Configuration settings.",
             variant: "destructive",
           });
           setConnectionStatus("error");