Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slow_mo photos always have hasadjustments=True even if not edited #256

Open
RhetTbull opened this issue Nov 7, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@RhetTbull
Copy link
Owner

Need to find a way to determine if slow_mo video really has adjustments.

I think I've found the problem and I've been able to replicate this. It appears that slow-mo videos are always marked as having adjustments (edits) in the database even if they haven't been edited. Instead of an edited video there's a .plist file and my guess is this contains the information for when to change frame rate between normal speed and slow motion. Thus, when using --skip-original-if-edited, osxphotos looks for an edited file but doesn't find one. If you actually edit the file, e.g. trim it, there will be an edited video generated and the export works as expected.

I'll add a check to osxphotos to look for this situation and export the original video if the file hasn't actually been edited.

Originally posted by @RhetTbull in #252 (comment)

@RhetTbull RhetTbull added the bug Something isn't working label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant