Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify start, all, and/or multiple properties of filters. #83

Open
samussiah opened this issue May 21, 2021 · 3 comments

Comments

@samussiah
Copy link
Contributor

Per @sibyllwangxxxx, would be nice to set default filters to multiple, and truly customize non-default filters.

@jwildfire
Copy link
Contributor

@samussiah I wonder if this is actually an update for webcharts.

@samussiah
Copy link
Contributor Author

samussiah commented May 23, 2021

webcharts supports start/all/multiple but the filters in most of the safety explorer modules are hard coded with only the value_col and label properties - even if other properties are specified.

@jwildfire
Copy link
Contributor

Riiiiiiiiight. I kinda remember this now.

Yeah, would definitely be nice to move to a more generic way to specify/initialize filters in renderers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants