Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in 0.0.16 (possibly related to bind:clientWidth?) #42

Open
francoislg opened this issue May 2, 2022 · 0 comments

Comments

@francoislg
Copy link

First of all, great package, I love it! :)

I am using this package to render a chart in a table, and it seems to be having performance issues starting with 0.0.16.

I have created a REPL so that you can test it out. Clicking on refresh should give you some number, which is a rough and inaccurate estimate of the time it took.

Now, run the same thing, but using 0.0.16. You can see it's about 2-3 times slower in the best cases.

When observing performance in the profiler, it seems to be related to style and layout recalculation.

0.0.15:

image

0.0.16:

image

Also, I noticed that some purple appeared during mount (which is what is causing major issues in my website):

0.0.15:

image

0.0.16

image

This looks pretty much like layout thrashing caused by bind:clientWidth and bind:clientHeight, but I could be wrong here.


I'm guessing this is a Svelte issue, but I'm wondering if we could do a quick fix in Pancake to bring back the original performance here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant