Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing responses is very counter-intuitive #35

Open
futpib opened this issue Jul 27, 2017 · 0 comments
Open

Throwing responses is very counter-intuitive #35

futpib opened this issue Jul 27, 2017 · 0 comments

Comments

@futpib
Copy link

futpib commented Jul 27, 2017

Whenever people write catch (err) or .catch(err => ...) they expect err to be instanceof Error or at least to have a somewhat similar interface to Error 🦆.

I suggest next major version throws errors with a response property set to the response which led to error (just like github/fetch suggests) instead of thowing responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant