Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make this a SuperApp to enable batchCall approve + swap #3

Open
mikeghen opened this issue Jun 20, 2022 · 1 comment · May be fixed by #2
Open

Make this a SuperApp to enable batchCall approve + swap #3

mikeghen opened this issue Jun 20, 2022 · 1 comment · May be fixed by #2
Labels
help wanted Extra attention is needed

Comments

@mikeghen
Copy link
Contributor

On the SuperSwap could I recommend using a batchCall to avoid the approve+swap double transaction?

Only problem is it would require a tiny change to the contract to enable the batch call (it needs to be a superApp)

Alternatively, an ERC777 Callback could be implemented to remove the double tx as well
@mikeghen
Copy link
Contributor Author

https://discord.com/channels/862796510604296263/986040775160766474/988232674432921634

@mikeghen mikeghen added help wanted Extra attention is needed $2500 bounty and removed $2500 bounty labels Jun 20, 2022
@shreyaspapi shreyaspapi linked a pull request Jun 21, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
1 participant
@mikeghen