Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit and correct fee calculation #5

Closed
mikeghen opened this issue Jul 26, 2021 · 0 comments
Closed

Audit and correct fee calculation #5

mikeghen opened this issue Jul 26, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mikeghen
Copy link
Contributor

I notice on some distributions the fee taken isn't exactly the rate currently programmed into the contract code. Im not sure where the miscalculation is but I believe the correct way to handle this is:

  1. write a unit test specifically to check the fee taken
  2. correct the logic if its found to be incorrect
@mikeghen mikeghen added bug Something isn't working good first issue Good for newcomers labels Jul 26, 2021
@mikeghen mikeghen closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikeghen