Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The variable aadarchi-version is not used in pom.xml #316

Closed
lhauspie opened this issue Feb 17, 2023 · 1 comment
Closed

The variable aadarchi-version is not used in pom.xml #316

lhauspie opened this issue Feb 17, 2023 · 1 comment

Comments

@lhauspie
Copy link

After generating the project with the archectype, the pom.xml define a property aadarchi-version that is not used in the rest of the file. It can be confusing because if I upgrade the version in properties, I expect to update all dependencies version at once what it will not be the case here.

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
...
	<properties>
...
		<!-- Defining a version that doesn't suck -->
		<aadarchi-version>0.1.6</aadarchi-version>
...
	</properties>

	<dependencies>
...
		<dependency>
			<groupId>io.github.Riduidel.aadarchi</groupId>
			<artifactId>base</artifactId>
			<version>0.1.6</version>
		</dependency>
		<dependency>
			<groupId>io.github.Riduidel.aadarchi</groupId>
			<artifactId>github-scm-handler</artifactId>
			<version>0.1.6</version>
		</dependency>
		<dependency>
			<groupId>io.github.Riduidel.aadarchi</groupId>
			<artifactId>adr-tickets-extractor</artifactId>
			<version>0.1.6</version>
		</dependency>
		<dependency>
			<groupId>io.github.Riduidel.aadarchi</groupId>
			<artifactId>maven-metadata-inferer</artifactId>
			<version>0.1.6</version>
		</dependency>
...
	<dependencies>
...
</project>
@lhauspie lhauspie changed the title The variable aadarchi-version is not used The variable aadarchi-version is not used in pom.xml Feb 17, 2023
@Riduidel
Copy link
Owner

Fixed by #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants