Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade programming language detection #375

Closed
Riduidel opened this issue Aug 23, 2023 · 2 comments
Closed

Upgrade programming language detection #375

Riduidel opened this issue Aug 23, 2023 · 2 comments
Assignees

Comments

@Riduidel
Copy link
Owner

          Okay ... it seems like hard injection of language was a mistake.

Indeed, to inject Java language, I first checked if some dependnecies were present and used that as an indicator of Java usage.
But it fails miserably when no dependency is important enough.
The method I will now use will be significantly harder.

  1. Detect if some language runtime is detected in dependencies (by checking if dependency has the "language" tag)
  2. If none is found, add a fake Java dependency (with the version) and link it to a fake mvnrepository artifact -the artifact will be created by Add to mvnrepository a fake artifact for Java versions aadarchi-technology-detector#5

Originally posted by @Riduidel in #373 (comment)

@Riduidel Riduidel self-assigned this Aug 23, 2023
@Riduidel
Copy link
Owner Author

In fact, it's not even the best way.
Currently, I think that the best way is to explore pom hierarchy looking for nearest compiler configuration.
This will give us the used Java version

@Riduidel
Copy link
Owner Author

In fact, we won't implement that for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant