Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(carousel): move arrows up and extend text width #633

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(carousel): move arrows up and extend text width #633

wants to merge 9 commits into from

Conversation

Iqro-dev
Copy link
Contributor

closes #632

@Iqro-dev Iqro-dev added the enhancement New feature or request label Oct 24, 2024
@Iqro-dev Iqro-dev self-assigned this Oct 24, 2024
@Iqro-dev Iqro-dev linked an issue Oct 24, 2024 that may be closed by this pull request
make name and progress bar full width on mobile and move arrows in carousel #632
Open
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rigtch-fm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 9:40pm
rigtch-fm-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 9:40pm

@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from 04db9a0 to b5a620b Compare October 24, 2024 13:04
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.48%. Comparing base (06fd3d8) to head (093a262).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   41.57%   41.48%   -0.10%     
==========================================
  Files         191      191              
  Lines        5551     5547       -4     
  Branches      404      401       -3     
==========================================
- Hits         2308     2301       -7     
- Misses       3243     3246       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from b5a620b to d0fd894 Compare October 24, 2024 13:23
@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from d0fd894 to 9eddc5b Compare October 24, 2024 13:27
@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from 9eddc5b to 487ac61 Compare November 18, 2024 18:50
@Iqro-dev Iqro-dev requested a review from Mnigos November 18, 2024 18:51
Mnigos
Mnigos requested changes Nov 23, 2024
View reviewed changes
Copy link
Member

@Mnigos Mnigos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole point of this change was to make the name longer
Screenshot 2024-11-23 at 14 20 14

@Iqro-dev Iqro-dev force-pushed the 632-make-name-and-progress-bar-full-width-on-mobile-and-move-arrows-in-carousel branch from e91a0f3 to 093a262 Compare November 23, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mnigos Mnigos Mnigos requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Iqro-dev Iqro-dev

Labels
enhancement New feature or request
Projects
rigtch.fm
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make name and progress bar full width on mobile and move arrows in carousel
2 participants
@Iqro-dev @Mnigos