Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchlist_days_to_remove must be non null even if remove_watchlist_items_older_than_x_days is false #151

Closed
1 task done
aaronsewall opened this issue Jan 23, 2025 · 1 comment · Fixed by #152
Closed
1 task done

Comments

@aaronsewall
Copy link

aaronsewall commented Jan 23, 2025

Is there already an issue for your problem?

  • I have checked older issues, open and closed

Bug Description

When running the setup code, and answering "n", credentials.txt (which is json), will be written as

{
...
    "remove_watchlist_items_older_than_x_days": false, 
    "watchlist_days_to_remove": null
}

When running again, the conditionals force the user to again answer the prompt because of

if (
    remove_watchlist_items_older_than_x_days is not None 
    and remove_watchlist_items_older_than_x_days != "empty"
    and watchlist_days_to_remove is not None
):
    return remove_watchlist_items_older_than_x_days, watchlist_days_to_remove  # Return stored values if they exist

I believe this is solved if the conditional and watchlist_days_to_remove is not None is removed.

Environment

OS: Linux
Using pip install method: no
Using manual no pip install method: yes

Screenshots

No response

@RileyXX
Copy link
Owner

RileyXX commented Jan 24, 2025

Thanks for reporting this. Should be fixed in v3.4.5.

python -m pip install IMDBTraktSyncer --upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants