Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Custom Presentation Renderer with new Roam API for Render Block #6

Open
dvargas92495 opened this issue Apr 27, 2023 · 2 comments

Comments

@dvargas92495
Copy link
Collaborator

Should knock out all future related features and condense a bunch of custom logic that we're doing

@mdroidian
Copy link
Contributor

another use case this should fix: Supporting images uploaded in an encrypted graph.
Reported by Dinesh C. via support@roamjs

@mdroidian
Copy link
Contributor

mdroidian commented Mar 31, 2024

https://github.com/RoamJS/presentation/tree/replace-renderer

  • split Presentation.tsx into components to make it easier to work
  • multiple type fixes
  • added renderBlock embed to start testing

TODO: create multiple test presentations

  • image, media, iframe
  • layouts
  • viewTypes
  • excalidraw
  • code blocks
  • latex
  • image in encrypted graph
  • google drive images
  • diagrams
  • tables / wb-table
  • mermaid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants