Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support #879

Open
dkarlovi opened this issue Dec 6, 2024 · 6 comments
Open

PHP 8.4 support #879

dkarlovi opened this issue Dec 6, 2024 · 6 comments

Comments

@dkarlovi
Copy link
Contributor

dkarlovi commented Dec 6, 2024

Since PHP 8.4 is now fully out, seems it could be supported here.

@Ocramius
Copy link
Member

Ocramius commented Dec 6, 2024

Hmm, unsure why there's no renovate pipeline for that.

This PR should be it: https://github.com/Roave/BackwardCompatibilityCheck/pull/769/files

Perhaps you can check what's up there?

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Dec 6, 2024

Looking at the pipeline, composer.json is requesting newer versions of stuff, but composer.lock (which is committed in the repo) isn't getting updated by renovatebot in the same PR, even though the docs claim they should be kept in sync?

@Ocramius
Copy link
Member

Ocramius commented Dec 6, 2024

That's probably because renovate can't run an update on 8.2.x then 🤔

@Ocramius
Copy link
Member

Ocramius commented Dec 7, 2024

We still need vimeo/psalm to release here first: not possible to upgrade earlier.

I'd suggest helping upstream here: vimeo/psalm#11035

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Dec 9, 2024

@Ocramius it seems the PR is basically done, but the review process is taking a while and it will cause a new major of Psalm anyway. It's generally a good idea not to install the QA tools as dev deps, you don't rely on them directly, you're just using them like a hammer in which case installing them in a separate root in a isolated way (via a separate composer.json or managed via https://github.com/bamarni/composer-bin-plugin) is way more preferable.

@Ocramius
Copy link
Member

It's a tool used as part of the runtime, not separately: it is part of the main dependencies, and not really a plugin/separate.

Happy to accept patches for https://github.com/Roave/infection-static-analysis-plugin/ that solve this at architectural level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants