Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[userscript] errors in console: TrustedScript assignment #53

Open
dnmTX opened this issue Jul 3, 2023 · 9 comments
Open

[userscript] errors in console: TrustedScript assignment #53

dnmTX opened this issue Jul 3, 2023 · 9 comments

Comments

@dnmTX
Copy link

dnmTX commented Jul 3, 2023

Hi Rob @Rob--W. I don't really know when it started happening but i see these errors in console and i'm not sure if the userscript is working as intended. I'm using the latest version of it as of 07-02-2023. Posting here screenshot from console.Anything else i can do on my end,just let me know. Thank you 👍
Capture

P.S. Just to note here. I do mask my User Agent(using Firefox UA,otherwise i'm on Chromium). Hopefully this is not what causing the errors.

Just in case,ping @ameshkov from the AdguardTeam as i'm not sure which is the problem here,the userscript or some settings in AG.
disableGoogleTracking.js.txt

@Rob--W
Copy link
Owner

Rob--W commented Jul 3, 2023

Please provide all necessary (but ideally minimal) details to reproduce this problem independently. At least:

  • browser and version (Chrome, but which version?)
  • which Google site to visit (ideally one that doesn't require a login)
  • what actions to take to trigger the error

And also: is this an AdGuard-specific issue?

  • does the issue also happen if you just copy-paste the full script to the Devtools?
  • if not, does the issue also happen if you use a different user script manager such as Tampermonkey?
  • Does the issue also happen if you install the Don't Track Me Google extension (instead of the user script)?

@dnmTX
Copy link
Author

dnmTX commented Jul 3, 2023

browser and version (Chrome, but which version?)

Slimjet Version 39.0.2.0 (based on Chromium 111.0.5563.41) (Official Build) (64-bit)

which Google site to visit (ideally one that doesn't require a login)

When i search in Google fo something(unfortunatelly i'm logged in all the time) that shows pictures in the results,like:
https://www.google.com/search?q=iphone+best+wallpapers
See screenshtot 👇

what actions to take to trigger the error

looks like when pictures are involved,when there aren't any,no errors showing up in console,like:
https://www.google.com/search?q=dont-track-me-google#ip=1

And also: is this an AdGuard-specific issue?

Let's wait for @ameshkov's input first before i go that road(if you don't mind). That's why i uploaded copy of my userscript if he want's to try to reproduce it.

Capture

@ameshkov
Copy link

ameshkov commented Jul 3, 2023

@dnmTX definitely it's on AG side

@dnmTX
Copy link
Author

dnmTX commented Jul 3, 2023

@dnmTX definitely it's on AG side

Oh wow,ok then.... Do i need to open issue there(which repo) or.......?

@ameshkov
Copy link

ameshkov commented Jul 3, 2023

@dnmTX no worries, I already did

@dnmTX
Copy link
Author

dnmTX commented Jul 3, 2023

Great and thanks for your help Andrey @ameshkov,it's allways appreciated here 👍
Rob @Rob--W thanks for your input and fast response and sorry to bother you with this.
I just wasn't sure where the problem is(was) 👍
Closing......

@dnmTX dnmTX closed this as completed Jul 3, 2023
@Rob--W
Copy link
Owner

Rob--W commented Jul 3, 2023

For visibility, the issue was filed at AdguardTeam/CoreLibs#1779

@ameshkov
Copy link

Hi all, we did some research on the issue and we'll probably won't fix it. The Tampermonkey's solution is relaxing CSP a little bit and I'd better avoid doing that: AdguardTeam/CoreLibs#1779 (comment)

Also, there's the same issue with Violentmonkey so maybe you'd want to fix it on the userscript side anyway. There're several simple ways to avoid this error: one is to use a policy when setting script's content, the other one is ignoring frames like google.*/uviewer.

@Rob--W
Copy link
Owner

Rob--W commented Aug 25, 2023

I'm re-opening this issue to consider something like AdguardTeam/CoreLibs#1779 (comment)

@Rob--W Rob--W reopened this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants