-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist for version 0.3.0 #46
Comments
I updated the checklist with everything I could think of. I have a week left before university starts again. |
Thank you very much for this nice list! |
I'll stay as co-author for now, and maybe reconsider after 0.3.0. Would it be possible for you to review a PR every week, only skipping a week occasionally whenever work is too hard or something? In the past there was periods of months between reviews, but I estimate that there will be ~20 PRs in between now and where I want 0.3.0 to be. |
It mostly depends on the reviewability of the incoming PRs. If a PR is easy to review I will mostly do it right away. If it takes several hours on the other hand I am taking more time to start the review. |
This semester is by far the hardest semester I have ever had. I have had to work on weekends and even during this spring break to keep the school work from running me over. I think I am feeling some burn out right now. I still want to get one more PR in before end of semester stuff kicks in. |
Issue #42 is fixed now, lets keep that issue up a little longer in case we encounter a problem. I will do a PR for issue #41 to have |
Here are the PRs that will need to be done before the crate is in a state that could be released.
digit.rs
usagestd_ops.rs
ShiftAmount
from PR Crate reorganization and upgrade to Rust 2018 #36 to fix issue Implement rotate functions for ApInts #28 and issue Document exactly when the left and right shifts return errors #23Bit
construct to directly use booleans and figure out what functions to keep for issue Let ApInt::resize_to_bool just return the least-significant bit (should be faster) #42NonZeroUsize
(MakeBitWidth
useNonZeroUsize
#39)MaybeUninit
From<[u64;2]>
functions use big endian #20, fix thefrom_vec_u64
TODOs)assign
and general ApInt construction #44) (not the arbitrary concatenation stuff, only constructor stuff)arithmetic.rs
intomul.rs
anddiv.rs
to use the simplified design from PR Crate reorganization and upgrade to Rust 2018 #36. This will also fix the remaining warnings and clippy warnings Fix clippy warnings #48.fuzz.rs
. Improve fuzz.rs #47 is unfortunately going to go unfixed until Rust fixes and stabilizes stuff related to RFC #2091.from_str_radix
into signed and unsigned versions #25contributions.md
stuff we wantThe text was updated successfully, but these errors were encountered: