Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidjson, please exchange it with a DFSG-compatible version #350

Closed
coldtobi opened this issue Oct 10, 2016 · 4 comments
Closed

rapidjson, please exchange it with a DFSG-compatible version #350

coldtobi opened this issue Oct 10, 2016 · 4 comments

Comments

@coldtobi
Copy link

Hallo Robert,

I'm in the progress of packaging a new snapshot for Debian and I just saw that rapdidjson has been added as a new external library and it is being used SWF stuff (as far I could see is)

Would it be ok to look into replacing it with e.g. https://android.googlesource.com/platform/libcore/+log/master/json, a reimplementation of the library. Reason for the request is that the license of rapidjson is not free (as per Debian defintion) due to the problematic "Good not Evil" clause.
https://wiki.debian.org/qa.debian.org/jsonevil expands on this topic.

Many thanks for considering.

coldtobi

@coldtobi
Copy link
Author

PS: Seems that rapidjson has fixed it [1], so alternatively please pull to a more recent version. Thanks!

[1] Tencent/rapidjson#377

@DanielGibson
Copy link

It wasn't "fixed", it was clarified that it hasn't been an issue to begin with, as it only affected a few test .json files (JSON_checker https://github.com/miloyip/rapidjson/tree/master/bin/jsonchecker) which are not included in this project.

@coldtobi
Copy link
Author

Yes, you're right.
So the bug can be closed (but it would be good to update the lib to latest anyway and maybe also document that the dir has been removed...)

@DanielGibson
Copy link

yeah, upgrading to the latest version is usually a good idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants