-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer bigint data type #893
Conversation
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 117 117
Lines 1126 1127 +1
Branches 129 129
=======================================
+ Hits 1072 1073 +1
Misses 22 22
Partials 32 32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Brobin, awesome, can you please update the Type inference table in readme file?
I need Json, what can I do |
This PR infers the data type of
bigint
toDataTypes.BIGINT
. Previously, using just@Column
on a bigint field produced this error:Specified type of property 'id' cannot be automatically resolved to a sequelize data type. Please define the data type manually
This will lead to cleaner code as the dataType argument can be removed from
@Column(DataType.BIGINT)