Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX suggestion - changing title bar as additional event notification (in addition to ring) #283

Closed
kristapsk opened this issue Oct 13, 2022 · 3 comments · Fixed by #315
Closed
Labels
enhancement 🆙 New feature or request

Comments

@kristapsk
Copy link

When other party takes your order, there is a bell (audio) notification. But in Tor Browser by default NoScript disables media playback, so user will not notice that, unless manually confirming specific media file. Instead there is just this following error popup:
image

Would be cool to have some blinking / changing title as additional notificaiton option, so that user could have his Tor Browser minimized in the title bar and see notification there. You could also just be having sound on your computer muted for some reason as well. Something like https://stackoverflow.com/a/7617318/2704037.

@Reckless-Satoshi Reckless-Satoshi added the enhancement 🆙 New feature or request label Oct 13, 2022
@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented Oct 13, 2022

Changing the page title is a very clever way to bring the user attention. I think using some bright/colorful emojis for each state and making them blink will do the job very well. Cool idea!!

And indeed, NoScript blocks sound notifications #41 . Experiene so far is that a newly installed Tor Browser that has not been customize will not block RoboSats sounds (tested in Windows & Linux). In addition to that, bringing push notifications to the native Android app is the best way to go.

@kristapsk
Copy link
Author

Experiene so far is that a newly installed Tor Browser that has not been customize will not block RoboSats sounds (tested in Windows & Linux).

For me it's blocked by default (on Gentoo Linux, but not installed from OS packages).

@Reckless-Satoshi
Copy link
Collaborator

The new Notification component will make the tab blink with a custom message for every notification type. The blinking page title will only fire if the user is in another tab (it will not fire if the tab is on focus and the user is in another application). On user return to page, the blinking will stop. There are new notifications for "User has rewards" and "There is a new message in the chat". All notifications fire regardless of where the user is in the app, as long as the user has an active order.

The sounds are now fired from a hidden div, so in case of conflict with NoScript it should not cause any UI issue (untested).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🆙 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants