Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referral codes persistence and links with Robots #91

Open
ghost opened this issue Apr 9, 2022 · 3 comments
Open

Referral codes persistence and links with Robots #91

ghost opened this issue Apr 9, 2022 · 3 comments
Labels
bug 🐛 Something isn't working

Comments

@ghost
Copy link

ghost commented Apr 9, 2022

Describe the bug

If a Robot is not used in some time, the associated Referral code can't be recovered, because recovering the Robot creates a new Referral code.

To Reproduce

  1. Generate a new Robot
  2. Click on 'Your Profile'
  3. Activate 'Rewards and compensations'
  4. Save the 'Referral link'
  5. Don't trade and close the website
  6. Recover the Robot the next day
  7. See that you have the same Robot buy a new Referral code/link

Expected behavior

The user can think to generate a Referral link, share it and recover future earnings some time later.

Additional context

If a robot has no history, it's deleted automatically at midnight. By logging in again the next day, you have deterministically generated the same robot (same name and avatar, but another referral link).

Ref: #62 (comment)

@Reckless-Satoshi Reckless-Satoshi added the bug 🐛 Something isn't working label Apr 11, 2022
@ghost
Copy link
Author

ghost commented May 25, 2022

Another scenario:

  • Robot 1 have no history for now.
  • Robot 1 shared his referral link.
  • Robot 2 uses the one's link.
  • Robot 2 starts a trade, but does not end it that day, but after midnight.
  • Robot 1 loses his link and reward.
  • Robot 2 loses its conditions? (not sure)

@0xtrr
Copy link

0xtrr commented Jun 18, 2022

Would love to see robots with persistent referral links. I use a referral link in my robosats orderbook nostr bot which kind of depend on the referral link to be persistent. I imagine there's a lot of other similar scenarios that would need this.

@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented Jun 18, 2022

Would love to see robots with persistent referral links. I use a referral link in my robosats orderbook nostr bot which kind of depend on the referral link to be persistent. I imagine there's a lot of other similar scenarios that would need this.

As of now there is a trick to make sure your robot referral is permanent: create a robot and make a small trade of $5 USD with yourself. You can even use collaborative cancel after commiting the Sats. Since the robot has some 'history' it will never be killed by the cleaning service and the referral link will be permanent :)

Solving this issue for good is in the list and will be done soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants