Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualified_predicates #217

Closed
cbizon opened this issue Apr 2, 2024 · 2 comments
Closed

Add qualified_predicates #217

cbizon opened this issue Apr 2, 2024 · 2 comments
Assignees

Comments

@cbizon
Copy link
Contributor

cbizon commented Apr 2, 2024

See NCATSTranslator/Feedback#744

We make a lot of affects predicates but many (all?) of these will also need the qualified predicate = causes on them. It's a bit goofy IMO, but the Translator UI is looking for those so it will help downstream.

@EvanDietzMorris
Copy link
Contributor

We actually have these already on all edges where an unqualified predicate is mapped to a qualified predicate using the biolink model (in ORION using https://bl-lookup-sri.renci.org/docs) - except as Colleen points out there are cases where the qualified_predicate is missing from the mapping in the model, so those would be missing. The example provided by Matt may be coming from a non-automat KP, all of the affects edges between those two nodes have the qualified_predicate already in robokop.

However, there are cases where we create edges with qualified predicates in parsers, and in these cases there is currently no verification that the set of qualifiers is complete or a valid combination.

@cbizon
Copy link
Contributor Author

cbizon commented Apr 2, 2024

Oh great. I will close this ticket then and followup with Matt to figure out where that edge is coming from.

@cbizon cbizon closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants