Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin shown in debugger but not in result #25

Open
Exorcismus opened this issue Mar 27, 2019 · 5 comments
Open

pin shown in debugger but not in result #25

Exorcismus opened this issue Mar 27, 2019 · 5 comments
Labels

Comments

@Exorcismus
Copy link

the tool debugger seems to detect the pins correctly, yet the result table not displaying some
image
pin 2,7 are missing
image

@sebcaux
Copy link
Member

sebcaux commented Mar 27, 2019

Could you please give me the link of the datasheet you use?
When a pin name have a square in blue, it has been associated to a pin. In green, no associations have been found.

@Exorcismus
Copy link
Author

please find it below , page 17
pdf

@Exorcismus
Copy link
Author

Could you please give me the link of the datasheet you use?
When a pin name have a square in blue, it has been associated to a pin. In green, no associations have been found.

this works for pin 2, but what about pin 7 ?, maked blue , yet, no association

@sebcaux
Copy link
Member

sebcaux commented Mar 27, 2019

... good question, pin 7 is associated yes, but with the upper package.
I will try to fix it soon.

@sebcaux sebcaux added the bug label Apr 7, 2019
@Exorcismus
Copy link
Author

Exorcismus commented Apr 10, 2019

as the word width is higher than it's height, the application dealt with it as horizontal word, while it should have dealt with it as vertical word
it seems the below condition is the reason in failing to detect alignement correctly,
I had to chage
if (label.pos.width()> label.pos.height() || label.text.count() <= 2)
to
if (label.pos.width()-1 > label.pos.height() || label.text.count() <= 2)
, any chance we might be able to tune the alignment algorithm ?
`bool DatasheetBox::isAlign(const DatasheetBox &label, const DatasheetBox &number)
{

// Horizontal
//TODO replace this small label test with a real margin test

if (label.pos.width()-1 > label.pos.height() || label.text.count() <= 2)
{
    qreal marge = label.pos.height();
    if (label.pos.height() > number.pos.height() * 2
     || number.pos.height() > label.pos.height() * 2)
        return false;
    if (label.pos.top() - marge < number.pos.top() &&
        label.pos.bottom() + marge > number.pos.bottom())
        return true;
    else
        return false;
}
else  // Vertical
{
    qreal marge = label.pos.width();
    if (label.pos.left() - marge < number.pos.left() &&
        label.pos.right() + marge > number.pos.right())
        return true;
    else
        return false;
}

}`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants