Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

NewClient with no errors and support for Go 1.5 #55

Closed
nathany opened this issue Jun 10, 2016 · 2 comments
Closed

NewClient with no errors and support for Go 1.5 #55

nathany opened this issue Jun 10, 2016 · 2 comments

Comments

@nathany
Copy link
Contributor

nathany commented Jun 10, 2016

Using x/net/http2 directly instead of ConfigureTransport could allow support for Go 1.5.x (if desired), and make it so NewClient() doesn't return an error.

https://github.com/sideshow/apns2/blob/master/client.go#L60
@nathany
Copy link
Contributor Author

nathany commented Jun 10, 2016

With Go 1.7 coming out in a few months, I don't see a lot of value in adding support for Go 1.5. But not needing to return an error would be nice.

@nathany nathany changed the title support Go 1.5? support Go 1.5 and NewClient with no errors Jun 10, 2016
@nathany nathany changed the title support Go 1.5 and NewClient with no errors NewClient with no errors and support for Go 1.5 Jun 10, 2016
@nathany
Copy link
Contributor Author

nathany commented Jun 15, 2016

#63 JWT would remove the need for NewClient.

@nathany nathany closed this as completed Jun 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathany