Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for RequestLog objects with no task result #115

Closed
helrond opened this issue Mar 5, 2020 · 0 comments · Fixed by #125
Closed

Improve error handling for RequestLog objects with no task result #115

helrond opened this issue Mar 5, 2020 · 0 comments · Fixed by #125
Labels
verified
Milestone
v1.1

Comments

@helrond
Copy link
Member

helrond commented Mar 5, 2020

Describe the bug

When request fail without getting a response from a service, the corresponding RequestLog object does not have a TaskResult associated with it. This causes downstream errors.

Expected behavior

Some areas that will need to be addressed:

  • The error_messages method on the RequestLog model, which presumed a TaskResult (line 146)
  • The ResultsDataTableView (line 240 in views.py)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
verified
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

v1.1 RockefellerArchiveCenter/zodiac
1 participant
@helrond