Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell check hell : impossible to change language or disable it #1520

Closed
2 tasks done
ThomasKientz opened this issue Feb 13, 2020 · 22 comments
Closed
2 tasks done

Spell check hell : impossible to change language or disable it #1520

ThomasKientz opened this issue Feb 13, 2020 · 22 comments
Labels
feat: spell checker Tasked Added to the internal issue tracking type: bug

Comments

@ThomasKientz
Copy link

ThomasKientz commented Feb 13, 2020

My Setup

  • Operating System: 10.15.3
  • App Version: v2.17.7
  • Installation type: dmg
  • I have tested with the latest version
  • I can simulate the issue easily

Description

Spell check is enabled but probably set to a different language that my system. I can not find a way to disable it or to set the language to french.

Impossible to change the language to French which is in the list and no option to disable spellcheck.

When I select French and go back, "Default" is still active.
Capture d’écran 2020-02-14 à 09 50 48

I have never added any dictionary or anything before.

@tassoevan
Copy link
Collaborator

Please fill the issue template. This info is important to help you.

@ankar84
Copy link

ankar84 commented Feb 14, 2020

v2.17.7

Impossible to change the language to French which is in the list and no option to disable spellcheck.

I have never added any dictionary or anything before.

2.17.7 should ask only 2 directory for dictionaries on Windows:
c:\Program Files\Rocket.Chat\resources\dictionaries
c:\Users\UserName\AppData\Roaming\Rocket.Chat\dictionaries
And shouldn't use system dictionaries.
In my case both true.

@ThomasKientz
Copy link
Author

Please fill the issue template. This info is important to help you.

@tassoevan done

@tassoevan
Copy link
Collaborator

@ThomasKientz

Spell check is enabled but probably set to a different language that my system. I can not find a way to disable it or to set the language to french.

If you right-click in any editable area (e.g. the message composer box), you'll see an Spelling languages menu (or Langages if French was detected from your operating system). Then you can set then spell checking dictionaries you want to use.

If you have any suggestions to improve this, I'd love to know.

When I select French and go back, "Default" is still active.

Looks like a bug in the Rocket.Chat server itself. Do you have access to its version?

@ThomasKientz
Copy link
Author

ThomasKientz commented Feb 14, 2020

@tassoevan

If you right-click in any editable area (e.g. the message composer box), you'll see an Spelling languages menu (or Langages if French was detected from your operating system). Then you can set then spell checking dictionaries you want to use.

Was not aware of that! French is not part of the list, how can I add it ?

Capture d’écran 2020-02-14 à 10 17 25

If you have any suggestions to improve this, I'd love to know.

Maybe an additional setting "spell check language" option ?

Thanks for the support

@tassoevan
Copy link
Collaborator

tassoevan commented Feb 14, 2020

@ThomasKientz I think I've let the Rechercher un langage ... disabled on MacOS by mistake (I'm considering to patch it right now), but as workaround you can copy a pair of files [language].aff and [language].dic to ~/Library/Application Support/Rocket.Chat/dictionaries. I'd recommend https://github.com/wooorm/dictionaries/blob/master/dictionaries/fr/index.aff and https://github.com/wooorm/dictionaries/blob/master/dictionaries/fr/index.dic, renamed as fr.aff and fr.dic.

@anne-pacalet
Copy link

On my Ubuntu 16.04, I created the ~/.config/Rocket.Chat/dictionaries/ and imported the two files suggested above, and now I can choose the fr language in the Language menu, but it does nothing... The spell checking is still in English (en_US is always selected each time I open the Language menu).

@strapsi
Copy link

strapsi commented Apr 20, 2020

i have the same problem with the windows client (v 2.17.7). if i disable the spell checking it gets enabled the next time i start the rocketchat client and is set to en_US

@Coriou
Copy link

Coriou commented Apr 20, 2020

Same issue as the two above on the Mac client.

Is there any reason not to use the OS' spellchecker ? I use mostly computers running MacOS and they come with a system-wide spellchecker / dictionary. I believe this is how it was implemented in Discord for example, another cross-platform Electron app. Just a question here, haven't explored the technical feasibility of this on each platform.

@thakilla
Copy link

Yeah it's realy annoying. Choosen language is being reset all the time. (Mac OS)

@jpele-tis
Copy link

Best way to fix this is to add manually the French or other language dictionnary.
You can download it in LibreOffice project : https://github.com/LibreOffice/dictionaries/tree/master/fr_FR
Download : fr.aff and fr.dic and place it here : C:\Program Files\Rocket.Chat\resources\dictionaries

@haldyr
Copy link

haldyr commented Jul 17, 2020

Best way to fix this is to add manually the French or other language dictionnary.
You can download it in LibreOffice project : https://github.com/LibreOffice/dictionaries/tree/master/fr_FR
Download : fr.aff and fr.dic and place it here : C:\Program Files\Rocket.Chat\resources\dictionaries

For languages with diacritics you need to also convert it to UTF-8.

@rsjr rsjr added the Tasked Added to the internal issue tracking label Jul 17, 2020
@SwampFalc
Copy link

Just FYI: the same issue happens on my 2.17.11 client on Linux. I keep turning spellcheck off (I'm working in a tri-lingual group of people so it's useless) and every time I start the client it resets to en_US.

@ankar84
Copy link

ankar84 commented Oct 1, 2020

Fixed in 3.0
image

@juice9990
Copy link

The problem still exists on rocket chat client version 3.0.6. After turning this off by deselecting English and restarting rocket chat, English is by default selected again.

@ankar84
Copy link

ankar84 commented Jan 21, 2021

The problem still exists on rocket chat client version 3.0.6. After turning this off by deselecting English and restarting rocket chat, English is by default selected again.

Why don't you try latest 3.1.1 version?

@juice9990
Copy link

juice9990 commented Jan 21, 2021

3.0.6 was the version linked on https://rocket.chat/ but I also checked 3.1.1 later after writing this comment and the problem still exists also on 3.1.1. Also, I thnk there was nothing in the changelog that would suggest this was fixed? I installed an old version of rocket chat - 2.16.2 and this bug is not there.

Also, we use quite old server version 2.0.1 - no time to update it. I guess when we find more time, we will update the server and then I will try the latest client again.

@fenjen
Copy link

fenjen commented Mar 1, 2021

I can confirm it seems to be impossible to start RocketChat 3.1.1 with a disabled spell checker. I have to do disable spell check manually every time I start RocketChat (every day).

@juice99
Copy link

juice99 commented Sep 22, 2021

It's still happening in the latest Rocket Chat. It is very annoying. Will this ever be fixed?

@ankar84
Copy link

ankar84 commented Sep 23, 2021

It's still happening in the latest Rocket Chat. It is very annoying. Will this ever be fixed?

Not confirm that.
Just tested on 3.5.5 - spell check languages are changing (enable and then disable some of them) and works perfect.

@fenjen
Copy link

fenjen commented Sep 23, 2021

Just downloaded the 3.5.6 and I'm able to disable spell checking now 👍 After a restart, despite en-US is automatically turned back on, RocketChat doesn't show red lines. I don't know whether that is intended, but as long as I can restart without getting red lines, it's fine for me. Thanks!

@ankar84
Copy link

ankar84 commented Sep 23, 2021

I don't know. I use only Russian dictionary and every restart I have only that language selected.
So, I'm closing that issue because it solved some versions ago.
image

@ankar84 ankar84 closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: spell checker Tasked Added to the internal issue tracking type: bug
Projects
None yet
Development

No branches or pull requests