Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Improve away detection #1542

Merged
merged 2 commits into from
Mar 10, 2020
Merged

perf: Improve away detection #1542

merged 2 commits into from
Mar 10, 2020

Conversation

Somtozech
Copy link
Contributor

@Somtozech Somtozech commented Mar 9, 2020 •
edited
Loading

Closes #194

Sets the user preference to away when the laptop's screen goes blank(sleep), the lid is shut or screen is locked (windows OS)

@tassoevan tassoevan changed the title Improve: Improve Away Detection perf: Improve away detection Mar 10, 2020
@tassoevan tassoevan added this to the 3.0.0 milestone Mar 10, 2020
tassoevan
tassoevan approved these changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! I've assumed that powerMonitor.getSystemIdleState() would take care of those cases, which is obviously wrong. Thank you!

@tassoevan tassoevan merged commit 6449554 into RocketChat:develop Mar 10, 2020
This was referenced Oct 6, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
feat: web view type: enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Improve away detection
2 participants
@Somtozech @tassoevan