Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeplink for Authentication Broken #2987

Closed
HiveMindNet opened this issue Mar 16, 2021 · 4 comments · Fixed by #3015
Closed

Deeplink for Authentication Broken #2987

HiveMindNet opened this issue Mar 16, 2021 · 4 comments · Fixed by #3015
Assignees
Labels

Comments

@HiveMindNet
Copy link

Description: When clicking a previously before working deep link with authentication, the URL seems to add to the app but the credentials are not applied and the user is not logged in.

Environment Information:

  • Rocket.Chat Server Version: 3.12.1
  • Rocket.Chat App Version: 4.15.0
  • Device Name: iPhone 12 Pro Max
  • OS Version: 14.4

Steps to reproduce:

  1. Install the app
  2. Open deeplink in browser

Expected behavior:

Should configure app and log user in

Actual behavior:

Configures server name then stops

Additional context:

none

@diegolmello
Copy link
Member

Can you add detailed info?

@HiveMindNet
Copy link
Author

HiveMindNet commented Mar 16, 2021

Hi @diegolmello sure :)

  1. We use iFrame auth so that users use the log in from our website to authenticate within Rocket when on the website; not just for using the app, for all. (WORKS)
  2. We use the API to create and get the authToken as per /api/v1/users.createToken. (WORKS)
  3. We publish on our website an auth_link such as: https://go.rocket.chat/auth?host=ourdomain.com&token=' . $authToken . '&userId=' . $userId; (WORKS still on desktop app)
  4. User can install the app without set up and just use this above auth_link when logged in to our website and the link previously would configure the mobile app and then log the user in. (BROKEN)

This is in link with these instructions: https://docs.rocket.chat/guides/developer/deeplink#authentication

@txwheeler
Copy link

I can confirm that this does not work. If I test this on iOS mobile app version 4.14.1.22787 it works. If I test on iOS mobile version 4.15.0.23394 it will not work.

As @HiveMindNet said, we are using the same process for the deeplink authentication. It works well from a pc to desktop app or pc to web application.

@nmagedman
Copy link
Contributor

nmagedman commented Mar 22, 2021

metoo.

What @HiveMindNet describes is exactly almost the same as our use-case (we don't use an iframe) and perfectly describes the problem we are seeing. We only noticed it after upgrading our RC server from 3.6.0 to 3.12.1. The RC iphone/android client upgrade came at about the same time, so the immediate cause is not clear. Like @txwheeler, we can still launch the web-client via a token, but not the mobile app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants