Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better message actions #329

Closed
diegolmello opened this issue Jun 15, 2018 · 7 comments · Fixed by #567
Closed

Better message actions #329

diegolmello opened this issue Jun 15, 2018 · 7 comments · Fixed by #567

Comments

@diegolmello
Copy link
Member

https://github.com/beefe/react-native-actionsheet works fine on iOS, but is very ugly and performs poorly on Android.
Maybe switch it by https://github.com/yfuks/react-native-action-sheet.
image

@saketkumar
Copy link
Contributor

@diegolmello
Copy link
Member Author

@saketkumar95 Hey, man. Expo's version uses a JS based implementation on Android and need a wrapper around entire app in order make it work.
I think it's a little weird.

https://github.com/yfuks/react-native-action-sheet is native (iOS/Android) and needs no render component on the tree. Still needs a work to see if works properly, but it sounds a better choice.
What do you think?
Do you want to contribute?

@saketkumar
Copy link
Contributor

yeah that's cool.
And yes I'll be working on this. :)

@saketkumar saketkumar self-assigned this Jun 27, 2018
@diegolmello
Copy link
Member Author

@saketkumar95 Great!

@diegolmello
Copy link
Member Author

@saketkumar95 Are you still working on this? It's been 15 days since your last commit and your PR still doesn't pass on lint.

@ghost
Copy link

ghost commented Jan 13, 2019

i want to work on this.

@ghost ghost unassigned saketkumar Jan 13, 2019
@diegolmello
Copy link
Member Author

@reduxsaga There's an open PR here #567.
It's already approved and it'll be merged soon.
If you still want to help, you can find out what's happening on connect/login: #571 and #581.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants