Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Group notifications by room #391

Closed
3 tasks
diegolmello opened this issue Jul 30, 2018 · 8 comments
Closed
3 tasks

[NEW] Group notifications by room #391

diegolmello opened this issue Jul 30, 2018 · 8 comments

Comments

@diegolmello
Copy link
Member

  • Group notifications by room
  • Show room icon
  • Reply from notification
@BenWildeman
Copy link

BenWildeman commented Feb 17, 2019

@diegolmello I've been playing around with notifications on this repo as a test bed for my own application, and I'm wondering if grouping of notifications is the way you actually want to go?

the reason I ask, is because grouping the notification by channel would make sense only if this was like an email application, but it's not. when tapping on the notification, it will send you to the same place, regardless of what notification you tapped on, aka, the channel in which it's in regards to.

you could however group them by host, which would make more sense, and then¹ use a combination of inbox style/messaging style notifications for the rest, so you're minimising the notifications visible in the notification shade (and group). You'd only need to update the notification in which the channel is in regards to, instead of creating a whole new notification for each push sent.

Edit:
¹using a combination of notification grouping and messaging style doesn't play nicely

however I do have them grouped as per this ticket which is as follows:
screenshot_20190217-223612

screenshot_20190217-223619

@BenWildeman
Copy link

example of messaging style notification:
screenshot_20190217-230404

@diegolmello
Copy link
Member Author

Very nice, @BenWildeman!
Can you open a PR with your progress?
What about notification reply? Have you played with?

@diegolmello diegolmello changed the title [Android] Group notifications by room [NEW] Group notifications by room Mar 13, 2019
@diegolmello
Copy link
Member Author

Hi, @BenWildeman!
Are you still working on this?

@BenWildeman
Copy link

short answer is no

@ggazzo
Copy link
Member

ggazzo commented Aug 7, 2019

short answer is no

do you have any draft or working in progress? maybe we could continue from there ;), thx

@BenWildeman
Copy link

you know what, I don't have anything to do this weekend so I can get this sorted for you guys 🙂

@ggazzo
Copy link
Member

ggazzo commented Aug 7, 2019

really thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants