Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve image preview #903

Closed
diegolmello opened this issue May 20, 2019 · 0 comments · Fixed by #1479
Closed

Improve image preview #903

diegolmello opened this issue May 20, 2019 · 0 comments · Fixed by #1479
Labels
🍭 good first issue 👍 improvement

Comments

@diegolmello
Copy link
Member

Currently, we're using react-native-image-zoom-viewer as image viewer.
Animations are too junky and it's not well maintained.

We need to refactor and split by OS:

iOS

iOS supports zoom by default on ScrollView. We need to wrap the image in a ScrollView and use maximumZoomScale

Android

It doesn't support zoom in the same way as iOS, so we need to have a separate logic.
react-native-reanimated is really awesome and have an ImagePreview example: https://github.com/kmagiera/react-native-reanimated/blob/master/README.md#100-declarative-gesture-interactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍭 good first issue 👍 improvement
Projects
None yet
Milestone
No milestone
1 participant
@diegolmello