-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching for an invalid RegExp shows UNDEFINED #1721
Comments
I think that could be confusing because that would lead me to think that my regexp was valid but not finding anything. Maybe use a better error message like An option to choose whether or not you want to search using a regexp would also be nice, because in this case it doesn't look like you intended |
Good point actually. I didn't realize that searching with regexes was a thing until I got that error message. An option to choose whether or not to use a regex for searching would probably be the best solution indeed. |
I think this has been resolved in #3850 |
@RocketChat/core the problem still persists on |
I think we don't need this page anymore.. that's why the link were removed. |
@sampaiodiego so should this issue be closed? |
@MartinSchoeler no.. we have to decide to whether remove the page or fix it. |
When searching for a string such as '(', which is an invalid regular expression the message 'Showing undefined results' is displayed.
I think there should be some error checking in order to display the 'Showing 0 results' message when an invalid regex is entered.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: