Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File posts by ignored users are still shown #23315

Closed
nmagedman opened this issue Sep 30, 2021 · 1 comment
Closed

File posts by ignored users are still shown #23315

nmagedman opened this issue Sep 30, 2021 · 1 comment

Comments

@nmagedman
Copy link
Contributor

Description:

If a user whom you are ignoring posts a regular text message, it shows the metadata (username and timestamp), but not the message itself. Instead, it shows "This message was ignored".

If that user posts a file upload, I would expect the image/document likewise to be concealed, same as for text messages. However, the file is still shown inline!

Steps to reproduce:

  1. Log in as User A and ignore User B.
  2. Log in as User B and post a text message and a file upload (e.g. an image).
  3. Log in as User A and view the room.

Expected behavior:

Both of User B's messages should be concealed, with an informative message of "This message was ignored".

Actual behavior:

User B's text message is concealed, but the file attachment is displayed.

In this screenshot, user "noach" is ignoring user "noach.mp". The latter posted an image, which is shown rather than hidden.
Screen Shot 2021-09-30 at 14 21 26

Server Setup Information:

  • Version of Rocket.Chat Server: 3.17.0
  • Operating System: Linux
  • Deployment Method: tar
  • Number of Running Instances: 30
  • DB Replicaset Oplog: enaabled
  • NodeJS Version: v12.22.1
  • MongoDB Version: 4.2.15 / wiredTiger (oplog Enabled)

Client Setup Information

  • Desktop App or Browser Version: Chrome 93.0.4577.63
  • Operating System: MacOS 10.15.7
@nmagedman
Copy link
Contributor Author

This has been fixed, possibly by #27630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant