Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple certificates/apps on Push Notification (iOS and Android) #5926

Closed
rafaelks opened this issue Feb 6, 2017 · 2 comments
Closed

Comments

@rafaelks
Copy link
Contributor

rafaelks commented Feb 6, 2017

Dear @RocketChat/core ❤️ ,

We currently support just one certificate (iOS) and one push-key (Android) to send push notifications. But since we'll now have more than one app for each platform, it would be required to support different keys.

My suggestion is to send the application id (or some unique identifier) when registering the device for push. On the JSON object today we currently have the appName that maybe can be used to that? We could have the app identifier here, instead of main. Example:

let request = [
    "msg": "method",
    "method": "raix:push-update",
    "params": [[
        "id": "some-crazy-string-here"
        "userId": "user-identifier",
        "token": ["apn": deviceToken],
        "appName": "com.rocket.chat.ios",
        "metadata": [:]
    ]]
]
@rodrigok
Copy link
Member

rodrigok commented Feb 6, 2017

@rafaelks Yes, that probably is the best way to do that.

@rafaelks
Copy link
Contributor Author

rafaelks commented Feb 8, 2017

Closing it since it's working fine after a few adjustments. Thanks @rodrigok. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants