Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] [i18n] Use enter separator rather than comma in highlight preferences #8377

Closed
mnlbox opened this issue Oct 3, 2017 · 2 comments · Fixed by #8433
Closed

[UX] [i18n] Use enter separator rather than comma in highlight preferences #8377

mnlbox opened this issue Oct 3, 2017 · 2 comments · Fixed by #8433

Comments

@mnlbox
Copy link

mnlbox commented Oct 3, 2017

Hi guys,
I want talk about this part of app:
highlight

I think it's better to use Enter character as a separator rather than comma in highlight preferences because comma in any language is difference for example in Arabic comma is ، but in English is , so it's so difficult to use highlight feature in other language with below steps:

  1. Type a word in Arabic
  2. Switch keyboard layout to English
  3. Type a comma
  4. Switch keyboard layout to Arabic
  5. Type another word

If we use Enter as a separator this feature can be more useful for non-English users.
I find related code here:

https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-ui-account/client/accountPreferences.js#L156

@mnlbox
Copy link
Author

mnlbox commented Oct 3, 2017

#8175

@cyclops24
Copy link
Contributor

@mnlbox, @karlprieb, @engelgabriel It's can be a useful improvement. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants