Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention here when offline/away shouldn't increase mention count #9375

Open
geekgonecrazy opened this issue Jan 10, 2018 · 4 comments
Open

Mention here when offline/away shouldn't increase mention count #9375

geekgonecrazy opened this issue Jan 10, 2018 · 4 comments

Comments

@geekgonecrazy
Copy link
Contributor

Description:

If someone uses @here while you are offline or away.. it shows as a mention. It doesn't alert me in anyway(which is fantastic) but... It still shows as a mention which is not accurate. Because I was not here at time of message so I shouldnt even get a mention.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.60.3
  • Operating System:
    open.rocket.chat

Steps to Reproduce:

  1. Join channel
  2. Disconnect
  3. Login with another user
  4. Mention @here
  5. Logged in with intial user
  6. You have a mention on that channel

Expected behavior:

No mention.. not part of @here when offline or away

Actual behavior:

Mention is added to channel subscription

@sampaiodiego
Copy link
Member

we used to have this behavior, but it was changed on purpose to the current one, your arguments are solid though.

at the time of that PR, I tested on Slack and it have that behavior, that's why I changed..

@geekgonecrazy geekgonecrazy changed the title Mention when offline/away shouldn't increase mention count Mention here when offline/away shouldn't increase mention count May 30, 2018
@geekgonecrazy
Copy link
Contributor Author

geekgonecrazy commented May 30, 2018

I mean it's not end of the world. Just kind of odd by very nature since if I'm not here then the notification doesn't apply to me. But since it doesn't notify its not that big of a deal to have unread.

I can close this since our current implementation is intentional :)

@mook-as
Copy link

mook-as commented Nov 30, 2018

Hi! I'm also seeing this, RC 0.71.1.

As far as I can tell (the description in #7059 is rather bare), it didn't attempt to differentiate here-while-online and here-while-away in the previous change. So it's likely that that change just missed the distinction. It would definitely still make sense to increment the mention count when the user is online and @here was mentioned in a different channel.

@ggazzo ggazzo added this to the 4.0.0 milestone Feb 6, 2020
@subham103
Copy link
Contributor

So should this issue be closed as there is an on-purpose change or we need to remove that user who is away from @here??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants